fix: Adds validation styles to datepicker #2398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
werdnanoslen
requested review from
gidjin,
haworku,
ahobson,
brandonlenz and
SirenaBorracha
as code owners
brandonlenz
requested changes
May 11, 2023
There was a problem hiding this comment.
Hey looks familiar 😆
With a couple unit tests to check that the right class is applied when the prop is set, I'm good to approve
brandonlenz
reviewed
May 11, 2023
brandonlenz
previously approved these changes
May 12, 2023
Co-authored-by: Brandon Lenz <brandon@truss.works>
brandonlenz
approved these changes
May 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds validation styles (and corresponding story) to DatePicker component, which uses a standard
<input>instead of our input component, which already has that validation.Related Issues or PRs
Resolves #2263
How To Test
validationStatuscontrolScreenshots (optional)